-
Notifications
You must be signed in to change notification settings - Fork 960
Offers when offer_paths are present and offer_issuer_id is not needed #8238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
longer needed. -There is a missing piece however in plugins/offers_invreq_hook.c, which causes an error in plugins/fetchinvoice.c when trying to fetch an invoice for an offer without offer_issuer _id. Comments were added to describe the remaining issue.
|
As requested by @vincenzopalazzo |
|
I thought this issue would be addressed in #8326 , but it was closed. As of 25.09rc2, it is still unresolved. For example:
|
blinded_node_id when offer_issuer_id is not present and offers_path is present.
86ec127 to
5c53729
Compare
|
@vincenzopalazzo I think I fixed the remaining issue with invoice_node_id when there is no offer_issuer_id . Note that the code that handles the signature will also need to be updated so the invoice gets signed by the final blinded_node_id instead of the node creating the invoice, as mentioned (but not described?) in the specifications. |
|
This invoice is invalid: let's break it down by type, length, value (hex)
This has no "b0" field (i.e. type: 176 ( To quote bolt12: And: So, who is producing this invalid invoice? |
-Fixing offers when offer_paths are present and offer_issuer_id is no longer needed.
-There is a missing piece however in plugins/offers_invreq_hook.c, which causes an error in plugins/fetchinvoice.c when trying to fetch an invoice for an offer without offer_issuer _id. Comments were added to describe the remaining issue.
Important
25.05 FREEZE MAY 12TH: Non-bugfix PRs not ready by this date will wait for 25.08.
RC1 is scheduled on May 23rd, RC2 on May 26th, ...
The final release is on MAY 29TH.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: